Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Improvent #1287

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Tabs Improvent #1287

merged 2 commits into from
Dec 23, 2024

Conversation

GGKapanadze
Copy link
Member

Description

This PR adds an improvement suggested by #1244

  • The UX improvements are done and tested
  • Secondary tabs CSS are added for the base_theme but we don't have the concept of secondary tabs in the design yet

image

@GGKapanadze GGKapanadze self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 7f86da2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ilo-org/styles Patch
@ilo-org/react Patch
@ilo-org/twig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GGKapanadze GGKapanadze linked an issue Dec 20, 2024 that may be closed by this pull request
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-twig-develop ready!

Name Link
🔨 Latest commit 7f86da2
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig-develop/deploys/67655c6538b7ac00080b0f99
😎 Deploy Preview https://deploy-preview-1287--ilo-ui-twig-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-react ready!

Name Link
🔨 Latest commit 7f86da2
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-react/deploys/67655c657b8d84000867d5f4
😎 Deploy Preview https://deploy-preview-1287--ilo-ui-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-twig ready!

Name Link
🔨 Latest commit 7f86da2
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig/deploys/67655c65163f7e00096781dd
😎 Deploy Preview https://deploy-preview-1287--ilo-ui-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justintemps justintemps merged commit 1fc6807 into develop Dec 23, 2024
13 checks passed
@justintemps justintemps deleted the feat/base-theme-tabs branch December 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement to the tabs components
2 participants